Review the build

Orient

Why this stage matters

Passing checks establish only what they observed. The reviewer must find mismatches, limit the release claim to the available evidence and identify the person who owns each remaining risk.

Inputs

Use repository sources and accepted artifacts

Worked example

Review one seeded mismatch

1. Select one accepted claim and locate its test and code.
2. Show that the test observes only the response status and misses stored balance state.
3. State the release claim that the available evidence cannot support.

The worked example models the comparison. The final patch removes the prompts.

Decide

Make the release decision from repository evidence

• Does the code implement every accepted claim at the correct boundary?
• Could the tests pass while the operation and balance diverge?
• Do transaction, retry and ownership claims exceed the evidence?
• Which existing CRUD paths remain unsafe or untested?
• Should the result ship, return for revision or stop?

Use the agent

Use the agent on this repository

These are task patterns for the pinned JHipster source, not answer scripts. Replace every bracketed field with accepted repository work. Open every cited path at the pinned revision and review each response before continuing. If you cannot supply a field, return to the earlier artifact.

Decide before prompting

• Open a new agent session with accepted artifacts, the full diff and command results.
• Make your own release decision before asking for a recommendation.

Review the full diff against the accepted change specification. Do not change code. For each claim, cite the implementing location and report satisfied, violated or not implemented. List code changes with no accepted claim.

Review the tests against the accepted claims and test specification. For each claim, cite the observing test and the state it checks. Identify missing cases and assertions that cannot prove the claim.

Review changed code against the test suite and command results. Identify unexecuted branches, untested mutation paths and tests that could pass with a plausible defect. State evidence limits.

Using only verified review findings, recommend ship, revise or stop. List the supporting evidence, remaining risks, evidence limits and owner for each risk. Do not treat a passing local build as production proof.

Create

Produce the build review and release decision for this repository

1. Compare each specification claim with the code.
2. Compare each specification claim with the tests and results.
3. Compare each test with the code path it claims to exercise.
4. Record limitations and assign an owner to each remaining risk.
5. Make an individual release decision and defend it with the trace.

Challenge

Try to disprove the repository-backed work

Revise

Use repository evidence before continuing

Independent transfer check

Review this new change without the stage prompts

Set a 10-minute timer. Copy your findings and release decision into the build review before opening the answer key.

Specification excerpt

C-1: Add the signed operation amount to the current account balance.
C-2: Save the operation and balance in one transaction.
C-3: Allow only the account owner to post an operation.
C-4: Reject updates and deletion after an operation is posted.

Implementation excerpt

var account = bankAccountRepository.findById(operationDTO.getBankAccount().getId())
    .orElseThrow();
assertCurrentUserOwns(account);

var newBalance = account.getBalance().subtract(operationDTO.getAmount());
account.setBalance(newBalance);
bankAccountRepository.save(account);
operationRepository.save(operationMapper.toEntity(operationDTO));

Test excerpt

restOperationMockMvc.perform(post("/api/operations")
        .contentType(MediaType.APPLICATION_JSON)
        .content(om.writeValueAsBytes(operationDTO)))
    .andExpect(status().isCreated());

assertThat(operationRepository.findAll()).hasSize(databaseSizeBeforeCreate + 1);

Transfer

Apply the practice to your work

• Apply the review trace to a current or recent pull request after the lab.
• Record what changed in the release decision because of the review.
• Share the resulting work sample with the course team for the delayed transfer check.

Record your answer. The lab is complete only when you can name the equivalent practice, artifact and evidence in your work.